1 files changed, 13 insertions, 11 deletions

diff --git a/jinwei.me/infra/s3.tf b/jinwei.me/infra/s3.tf
index 49f8e10..6c39e4c 100644
--- a/jinwei.me/infra/s3.tf
+++ b/jinwei.me/infra/s3.tf
@@ -2,12 +2,13 @@ resource "random_id" "s3_bucket_suffix" {
   byte_length = 4
 }
 
-resource "aws_s3_bucket" "main" {
-  bucket = "static.jinwei.me"
+resource "aws_s3_bucket" "static" {
+  # https://docs.aws.amazon.com/AmazonS3/latest/userguide/bucketnamingrules.html#:~:text=For%20best%20compatibility,in%20their%20names
+  bucket = "${var.name}-${random_id.s3_bucket_suffix.hex}"
 }
 
-resource "aws_s3_bucket_public_access_block" "main" {
-  bucket = aws_s3_bucket.main.id
+resource "aws_s3_bucket_public_access_block" "static" {
+  bucket = aws_s3_bucket.static.id
 
   # https://docs.aws.amazon.com/AmazonS3/latest/userguide/access-control-block-public-access.html
   block_public_acls       = false
@@ -16,12 +17,13 @@ resource "aws_s3_bucket_public_access_block" "main" {
   restrict_public_buckets = true
 }
 
-resource "aws_s3_bucket_policy" "main" {
-  bucket = aws_s3_bucket.main.id
-  policy = data.aws_iam_policy_document.bucket_policy.json
+resource "aws_s3_bucket_policy" "static" {
+  bucket = aws_s3_bucket.static.id
+  policy = data.aws_iam_policy_document.static_bucket_policy.json
 }
 
-data "aws_iam_policy_document" "bucket_policy" {
+
+data "aws_iam_policy_document" "static_bucket_policy" {
   # Allow Cloudfront to read from the bucket
   statement {
     principals {
@@ -34,7 +36,7 @@ data "aws_iam_policy_document" "bucket_policy" {
       "s3:GetObject"
     ]
     resources = [
-      "${aws_s3_bucket.main.arn}/*",
+      "${aws_s3_bucket.static.arn}/*",
     ]
     condition {
       test     = "StringEquals"
@@ -44,8 +46,8 @@ data "aws_iam_policy_document" "bucket_policy" {
   }
 }
 
-resource "aws_s3_object" "healthcheck" {
-  bucket       = aws_s3_bucket.main.id
+resource "aws_s3_object" "check" {
+  bucket       = aws_s3_bucket.static.id
   key          = "healthcheck"
   content      = "OK"
   content_type = "text/plain"